feat: Overhaul Github Actions #2040

ajnavarro · 2024-05-06T11:32:48Z

Github Actions refactoring

This PR aims to heavily simplify our CI and the way we are running our tests. To remove as much cognitive load as possible, Go default test commands are used for testing (a.k.a go test ./...) instead of intricated makefiles.

This PR is the first of several PRs cleaning and simplifying the test suite.

On this PR:

We are simplifying all the CI workflows using reusable workflows on all existing Go modules living on the monorepo.
Improvements made on contribs on chore: make contribs/ ci and makefiles dynamic #2013 are applied on this PR (CC @moul) (closes chore: make contribs/ ci and makefiles dynamic #2013)
Codecov tasks are also simplified, creating a tag per module, making codecov happier when uploading the reports and the code coverage report more understandable and easy to follow. Old tags must be deleted after merging this PR.
Now all tests are executed. The longest test suite is gnovm (6 mins). I don't think it is worth it to add the -short tag taking into account the extra work that it causes when tests are failing only in master because we are not running them on all the PRs. Apart from that, tests that should have been executed on CI are executed now.
Docker images are only built on master branch.

TODO:

These are some of the missing improvements on this PR that will be addressed in following ones:

Extra checks:

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

moul · 2024-05-06T12:14:36Z

Related with #2013

gnovm/tests/package_test.go

gnovm/tests/file_test.go

thehowl · 2024-05-06T15:46:54Z

Overall, you seem to be also making a work to ensure that the "standard scenario" for testing is one where doing "go test ./..." just works. I can agree with that; I'd like to see the exceptions we have on the Makefiles (and copied into the CI) reduced as well.

However, consider that aside from the -run flags in gnovm/Makefile exclude some tests (like challenges, and the packages), consider also that we always pass the -short flag when testing the tests/files directory because some files (the ones with _long.gno) take a huge amount of time.

They are currently not covered; if you want to test them by adding a daily CI (rather than one at each commit) testing for them then go for it. But the CI should still run these with -short.

codecov · 2024-05-06T15:53:39Z

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 21.79%. Comparing base (977a3f4) to head (29bd559).

Files	Patch %	Lines
misc/autocounterd/cmd/cmd_start.go	0.00%	6 Missing ⚠️
misc/loop/cmd/snapshotter.go	0.00%	3 Missing ⚠️
misc/loop/cmd/cmd_serve.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2040       +/-   ##
===========================================
- Coverage   55.01%   21.79%   -33.22%     
===========================================
  Files         481       24      -457     
  Lines       67432     2092    -65340     
===========================================
- Hits        37097      456    -36641     
+ Misses      27318     1619    -25699     
+ Partials     3017       17     -3000

Flag	Coverage Δ
contribs/gnofaucet	`14.46% <ø> (?)`
contribs/gnomd	`0.00% <ø> (?)`
gno.land-_test.gnokey	`?`
gno.land-_test.gnoland	`?`
gno.land-_test.pkgs	`?`
gnovm-_test.cmd	`?`
gnovm-_test.gnolang.native	`?`
gnovm-_test.gnolang.other	`?`
gnovm-_test.gnolang.pkg0	`?`
gnovm-_test.gnolang.pkg1	`?`
gnovm-_test.gnolang.pkg2	`?`
gnovm-_test.gnolang.realm	`?`
gnovm-_test.gnolang.stdlibs	`?`
gnovm-_test.pkg	`?`
go-1.21.x	`?`
go-1.22.x	`?`
misc	`?`
misc-_test.genstd	`?`
misc/autocounterd	`0.00% <0.00%> (?)`
misc/genproto	`0.00% <ø> (?)`
misc/genstd	`73.90% <ø> (?)`
misc/goscan	`0.00% <ø> (?)`
misc/logos	`17.38% <ø> (?)`
misc/loop	`0.00% <0.00%> (?)`
tm2-_test.flappy	`?`
tm2-_test.pkg.amino	`?`
tm2-_test.pkg.bft	`?`
tm2-_test.pkg.others	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zivkovicmilos

I might be crazy, but the CI on this PR is significantly faster and snappier 👀

Let's go 🚀

.github/workflows/lint_template.yml

.github/workflows/misc.yml

.github/workflows/test_template.yml

gnovm/pkg/gnolang/gno_test.go

gnovm/tests/file_test.go

gnovm/tests/package_test.go

misc/loop/cmd/cmd_serve.go

zivkovicmilos · 2024-05-10T14:30:03Z

@thehowl did you get a chance to recheck this? 👀

thehowl

overall LGTM. a few comments; on the ones from the previous review, please act on them and we should be good to go

.github/examples.yml

.github/workflows/DELETEdocker.yml

.github/workflows/build_template.yml

.github/workflows/main_template.yml

Signed-off-by: Antonio Navarro Perez <[email protected]>

future. Signed-off-by: Antonio Navarro Perez <[email protected]>

Signed-off-by: Antonio Navarro Perez <[email protected]>

@ajnavarro

cc/ @ajnavarro, related to #2040

@ajnavarro

cc/ @ajnavarro, related to gnolang#2040

Continues #2013 > People should focus on their contributions in the `contribs/MYFOLDER` without updating a shared `Makefile` + `.github/contribs/*.yml`. The CI part has been completed in #2040. This pull request handles the Makefile portion. --------- Signed-off-by: moul <[email protected]>

Continues gnolang#2013 > People should focus on their contributions in the `contribs/MYFOLDER` without updating a shared `Makefile` + `.github/contribs/*.yml`. The CI part has been completed in gnolang#2040. This pull request handles the Makefile portion. --------- Signed-off-by: moul <[email protected]>

github-actions bot assigned ajnavarro May 6, 2024

github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 6, 2024

moul mentioned this pull request May 6, 2024

chore: make contribs/ ci and makefiles dynamic #2013

Closed

github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 6, 2024

thehowl reviewed May 6, 2024

View reviewed changes

gnovm/tests/package_test.go Show resolved Hide resolved

gnovm/tests/file_test.go Show resolved Hide resolved

ajnavarro force-pushed the improv/overhaul-ci branch from 8ac1fd6 to 25ccd0e Compare May 6, 2024 19:37

Kouteki mentioned this pull request May 7, 2024

Minutes: Core Staff Weekly Syncs [every Monday] gnolang/meetings#36

Open

ajnavarro force-pushed the improv/overhaul-ci branch 4 times, most recently from 1213b51 to 4a11406 Compare May 8, 2024 09:22

ajnavarro marked this pull request as ready for review May 8, 2024 09:38

ajnavarro requested review from moul, a team, jaekwon, piux2, deelawn and mvertes as code owners May 8, 2024 09:38

zivkovicmilos approved these changes May 8, 2024

View reviewed changes

ajnavarro requested a review from thehowl May 8, 2024 15:59

thehowl mentioned this pull request May 9, 2024

In some cases, the value of Uverse is incomplete [WIP] #2067

Closed

thehowl approved these changes May 13, 2024

View reviewed changes

.github/examples.yml Outdated Show resolved Hide resolved

.github/workflows/DELETEdocker.yml Outdated Show resolved Hide resolved

.github/workflows/build_template.yml Outdated Show resolved Hide resolved

.github/workflows/main_template.yml Show resolved Hide resolved

ajnavarro added 3 commits May 13, 2024 16:23

WIP

e39111b

Signed-off-by: Antonio Navarro Perez <[email protected]>

All GH actions to workflows folder.

7815942

Signed-off-by: Antonio Navarro Perez <[email protected]>

Fix template path

a6f597f

Signed-off-by: Antonio Navarro Perez <[email protected]>

ajnavarro added 16 commits May 13, 2024 16:23

Set go version strings

6974446

Signed-off-by: Antonio Navarro Perez <[email protected]>

Ignore some tests and keep dependabot logic

d74b3c8

Signed-off-by: Antonio Navarro Perez <[email protected]>

Move contribs to a unique workflow to automatically add new ones in the

5ca38d5

future. Signed-off-by: Antonio Navarro Perez <[email protected]>

Fix dependabot and update some gh actions

19e9735

Signed-off-by: Antonio Navarro Perez <[email protected]>

Refactor misc workflow

1d28a62

Signed-off-by: Antonio Navarro Perez <[email protected]>

Fix tests and linter on misc

1bc47e5

Signed-off-by: Antonio Navarro Perez <[email protected]>

Fix lint errors

1ddf9f0

Signed-off-by: Antonio Navarro Perez <[email protected]>

fix linter errors

dd0180c

Signed-off-by: Antonio Navarro Perez <[email protected]>

Linter

304c85f

Signed-off-by: Antonio Navarro Perez <[email protected]>

Add db deps to benchmarks

4effca0

Signed-off-by: Antonio Navarro Perez <[email protected]>

Do not build docker images on PRs

17b4814

Signed-off-by: Antonio Navarro Perez <[email protected]>

Deactivate CGO in benchmarks

560a5b2

Signed-off-by: Antonio Navarro Perez <[email protected]>

Ignore benchmarks causing parsing errors

a1ef1d5

Signed-off-by: Antonio Navarro Perez <[email protected]>

Get back examples.yml and dependabot action groups

9641fe9

Signed-off-by: Antonio Navarro Perez <[email protected]>

Add comment explaining skip on benchmarks

a3b01f4

Signed-off-by: Antonio Navarro Perez <[email protected]>

Fix typo

d4ad4da

Signed-off-by: Antonio Navarro Perez <[email protected]>

ajnavarro force-pushed the improv/overhaul-ci branch 3 times, most recently from 29bd559 to d4ad4da Compare May 13, 2024 14:32

ajnavarro merged commit d7c04be into master May 13, 2024
186 of 187 checks passed

ajnavarro deleted the improv/overhaul-ci branch May 13, 2024 16:12

thehowl mentioned this pull request May 15, 2024

test(gnovm): re-enable stdlibs tests #2110

Merged

DIGIX666 pushed a commit to kazai777/gno that referenced this pull request May 15, 2024

feat: Overhaul Github Actions (gnolang#2040)

4138eef

michelleellen mentioned this pull request May 22, 2024

Minutes: Public Dev Calls [every Wednesday] gnolang/meetings#37

Open

thehowl added a commit that referenced this pull request May 27, 2024

test(gnovm): re-enable stdlibs tests (#2110)

ab7b9f9

cc/ @ajnavarro, related to #2040

omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024

test(gnovm): re-enable stdlibs tests (gnolang#2110)

5ce53ca

cc/ @ajnavarro, related to gnolang#2040

moul mentioned this pull request Jun 12, 2024

chore: make contribs/ Makefile dynamic #2318

Merged

moul mentioned this pull request Sep 21, 2024

ci: consider adding back the gnovm parallel testing #2826

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Overhaul Github Actions #2040

feat: Overhaul Github Actions #2040

ajnavarro commented May 6, 2024 •

edited

Loading

moul commented May 6, 2024

thehowl commented May 6, 2024

codecov bot commented May 6, 2024 •

edited

Loading

zivkovicmilos left a comment

zivkovicmilos commented May 10, 2024

thehowl left a comment

feat: Overhaul Github Actions #2040

feat: Overhaul Github Actions #2040

Conversation

ajnavarro commented May 6, 2024 • edited Loading

Github Actions refactoring

TODO:

Extra checks:

moul commented May 6, 2024

thehowl commented May 6, 2024

codecov bot commented May 6, 2024 • edited Loading

Codecov Report

zivkovicmilos left a comment

Choose a reason for hiding this comment

zivkovicmilos commented May 10, 2024

thehowl left a comment

Choose a reason for hiding this comment

ajnavarro commented May 6, 2024 •

edited

Loading

codecov bot commented May 6, 2024 •

edited

Loading